RN: fix heading anchor control #33125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's remove the external link for now.
enejb
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
dcalhoun
reviewed
Jul 1, 2021
There was a problem hiding this comment.
I tested the changes on an iPhone SE and Pixel 3a emulator. The results were as expected. 👍🏻
If @iamthomasbishop agrees with removing the external link as the appropriate fix, the code here looks good to me. That said, my personal thought is that it makes more sense to retain both the help text and link and appropriately style it for mobile. WDYT?
It looks like the help text was enabled in #30885, and we may have overlooked this one instance having styling issues. Regardless of what we land on, thank you for taking the time to put this fix together. Much appreciated!
I agree that the link is super helpful. I tried to make it display on the next line but I wasn't able to. :( The styles that I was applying to position things were mostly being ignored. Could it be because I was styling the trying to style an element that was already inside an element? Will try again tomorrow. |
It would appear that the styling issue may be related to nesting a Also, I'm not sure what you have tried thus far, but any styles prop set to If you continue to run into issues, let me know and I am happy to pull it down and see if I observe any opportunities. |
|
@enejb @dcalhoun Ideally allowing inline links in this type of scenario would be nice for future flexibility, but I’d also be fine with removing the link as a stop-gap fix with the expectation that the next iteration will include a link (whether that means pushing the link to a new row or an inline link). |
dcalhoun
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
The changes look good to me, and I agree it is an appropriate stop-gap fix for the time being. Verified the changes worked as expected, as mentioned earlier.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pr tries to fix the way the anchor setting looks in the mobile app.
I am not sure if this is the right fix. Should we remove the whole text on mobile?
cc: @iamthomasbishop
How has this been tested?
Screenshots
Before:
After:
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).