Enforce isAlternate on ToolbarDropdownMenu
#33129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
mkaz
as code owners
7 tasks
|
Size Change: +90 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
diegohaz
added
[Package] Components
mtias
reviewed
Jul 1, 2021
mtias
approved these changes
Jul 1, 2021
|
Thanks, @diegohaz ! |
12 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #32926 (comment).
Instead of manually setting
popoverProps={ { isAlternate: true } }every time we useToolbarDropdownMenu, the component should do that automatically.There's also a minor refactor on the component so the toggle props are properly merged with the internal
ToolbarItemprops (by passing the toggle props to theToolbarItemcomponent, and not directly to theDropdownMenucomponent). This may avoid future issues.Before
After