Fix: Preset variables not being used on the site editor. #33149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
force-pushed
the
fix/presets-variables-not-being-used-on-the-site-editor
branch
from
527a95a
to
ceb69b7
Compare
|
Size Change: +35 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
fix/presets-variables-not-being-used-on-the-site-editor
branch
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
12 tasks
gziolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We applied a change to keep all preset origins on our data structures but we missed an update to the variable resolution mechanism this made things on the site editor not use the variables as they should.
How has this been tested?
On the site editor, I applied a preset font family, color, and font size.
I verified on the frontend that the output of the styles of all these things uses CSS variables (on trunk values are used).
I created a user-defined color palette for the paragraph.
I applied a user color as the background of that paragraph I verified a variable was used for that style.