components: Add mergeEventHandlers #33205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +13.8 kB (+1%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
|
Something I noticed about this utility is that it creates an intersection of the left and right values + the rest of the left: I'm not sure this is the correct behavior... it seems like we should get back |
sarayourfriend
added
[Feature] Component System
ciampo
reviewed
Jul 7, 2021
ciampo
reviewed
Jul 7, 2021
This is what I'd expect too — I've also added a related comment which highlights where this potential bug may come from. Is there any real usage of this function, just to make sure that we're making the correct assumption about the way it should behave? |
ciampo
reviewed
Jul 7, 2021
|
Update pushed should address the issues. |
ciampo
reviewed
Jul 7, 2021
ciampo
reviewed
Jul 7, 2021
ciampo
reviewed
Jul 8, 2021
Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
sarayourfriend
added a commit
that referenced
this pull request
Jul 15, 2021
* components: Add mergeEventHandlers * Preserve the right hand sides non-interescting properties * Simplify merging logic * Update packages/components/src/utils/events.ts Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
mergeEventHandlersfunction that is needed by the TextInput component.How has this been tested?
Unit test should pass.
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).