Changelog generation: remove “experimental” status from WP 5.8 stable items #33214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
commented
Jul 6, 2021
bin/plugin/commands/changelog.js
Outdated
Comment on lines
62
to
73
| const LABEL_TYPE_MAPPING = { | ||
| '[Block] Navigation': 'Experiments', | ||
| '[Block] Query': 'Experiments', | ||
| '[Block] Post Comments Count': 'Experiments', | ||
| '[Block] Post Comments Form': 'Experiments', | ||
| '[Block] Post Comments': 'Experiments', | ||
| '[Block] Post Featured Image': 'Experiments', | ||
| '[Block] Post Hierarchical Terms': 'Experiments', | ||
| '[Block] Post Title': 'Experiments', | ||
| '[Block] Site Logo': 'Experiments', | ||
| '[Feature] Full Site Editing': 'Experiments', | ||
| 'Global Styles': 'Experiments', | ||
| '[Feature] Navigation Screen': 'Experiments', | ||
| '[Feature] Widgets Screen': 'Experiments', | ||
| '[Package] Dependency Extraction Webpack Plugin': 'Tools', | ||
| '[Package] Jest Puppeteer aXe': 'Tools', | ||
| '[Package] E2E Tests': 'Tools', |
There was a problem hiding this comment.
@priethor Anything else you're aware of we should remove the Experiments label from?
There was a problem hiding this comment.
Post Featured Image and Post Title are also making it in 5.8 and should not be experimental anymore.
With the Global Styles framework merged, would it make sense to mark it as non-experimental, even without the UI?
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
priethor
requested changes
Jul 6, 2021
bin/plugin/commands/changelog.js
Outdated
Comment on lines
62
to
73
| const LABEL_TYPE_MAPPING = { | ||
| '[Block] Navigation': 'Experiments', | ||
| '[Block] Query': 'Experiments', | ||
| '[Block] Post Comments Count': 'Experiments', | ||
| '[Block] Post Comments Form': 'Experiments', | ||
| '[Block] Post Comments': 'Experiments', | ||
| '[Block] Post Featured Image': 'Experiments', | ||
| '[Block] Post Hierarchical Terms': 'Experiments', | ||
| '[Block] Post Title': 'Experiments', | ||
| '[Block] Site Logo': 'Experiments', | ||
| '[Feature] Full Site Editing': 'Experiments', | ||
| 'Global Styles': 'Experiments', | ||
| '[Feature] Navigation Screen': 'Experiments', | ||
| '[Feature] Widgets Screen': 'Experiments', | ||
| '[Package] Dependency Extraction Webpack Plugin': 'Tools', | ||
| '[Package] Jest Puppeteer aXe': 'Tools', | ||
| '[Package] E2E Tests': 'Tools', |
There was a problem hiding this comment.
Post Featured Image and Post Title are also making it in 5.8 and should not be experimental anymore.
With the Global Styles framework merged, would it make sense to mark it as non-experimental, even without the UI?
@priethor I was thinking perhaps as the UI isn't finalised it's ok to keep Experimental and leave the release lead to move based on human understanding of whether it's a framework or a UI part.
Updated ✅ |
getdave
force-pushed
the
update/auto-changelog-labels
branch
from
f250cb8
to
c5a3596
Compare
|
Rebase to try and force the tests to pass... |
You've probably found it by now, but you can run It might be a bit tricky to run a version of that command that will include PRs with one of the labels that this PR moves out of Experimental. You could try removing the One of those hopefully touched one of the relevant blocks (e.g. Site Logo) 😄 |
|
I tested this using @ockham's suggestion and none of the items I've removed from the Experiments list in this PR showed up in the generated changelog under |
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
… items (#33214) * Remove “experimental” status from items to be released as stable in WP 5.8 * Remove additional blocks to implicit stable status
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working on Gutenberg release
11.0.0I kept having to move items out of experimental as they were now considered stable. This included:post-*blocks.This PR updates the script that auto generates the changelog to avoid grouping those items in the "Experimental" section.
How has this been tested?
Not actually sure how best to test. @ockham any ideas here?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).