Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PanelBody for InspectorControls #33227

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

mitogh
Copy link
Member

@mitogh mitogh commented Jul 6, 2021

Using PanelBody in the InspectorControls and example helps to get the styles and according styles out of the box.

Description

Updates on doc examples.

How has this been tested?

This is a doc update.

Screenshots

Types of changes

Documentation update

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

Using  `PanelBody` in the `InspectorControls` and example helps to get the styles and according styles out of the box.
@mitogh mitogh requested a review from ellatrix as a code owner July 6, 2021 16:13
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'm getting a crash when pasting the code in the console but it also happens on the trunk so it is another issue that should be addressed in a different PR.

@jorgefilipecosta jorgefilipecosta merged commit 76ddf21 into WordPress:trunk Jul 6, 2021
@github-actions github-actions bot added this to the Gutenberg 11.1 milestone Jul 6, 2021
@mitogh mitogh deleted the patch-1 branch July 6, 2021 16:37
sarayourfriend pushed a commit that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants