Tag Cloud: Remove editor style so editor matches frontend #33289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Jul 8, 2021
| @@ -7,7 +7,6 @@ | |||
| span { | |||
| display: inline-block; | |||
| margin-left: 5px; | |||
| color: $gray-700; | |||
| text-decoration: none; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
What about the rest of the styles in this file, are they needed?
There was a problem hiding this comment.
Feels some of them could be considered to be moved to style.css to have a slightly more opinionated block in terms of spacing.
There was a problem hiding this comment.
Yeah, I think the rest of the styles here might make sense to apply to the front-end.
I definitely agree with removing the gray color, but I think the non-underlined number and extra padding we have in the editor is a more polished visual treatment. I'd like to see that applied in both places.
There was a problem hiding this comment.
Good idea, PR updated...
|
Size Change: -162 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
kjellr
approved these changes
Jul 8, 2021
youknowriad
reviewed
Jul 8, 2021
| @@ -42,7 +42,6 @@ | |||
| @import "./social-links/editor.scss"; | |||
| @import "./spacer/editor.scss"; | |||
| @import "./table/editor.scss"; | |||
| @import "./tag-cloud/editor.scss"; | |||
There was a problem hiding this comment.
The more we remove these editor.scss files, the better is for parity :)
youknowriad
approved these changes
Jul 8, 2021
scruffian
force-pushed
the
update/tag-cloud-block-colors
branch
from
a43607d
to
da3d721
Compare
scruffian
force-pushed
the
update/tag-cloud-block-colors
branch
from
da3d721
to
b4b48d5
Compare
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Tag Cloud: Remove editor style so editor matches frontend * Remove all editor styles * move editor styles to the frontend
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the editor styles for Tag Cloud to the frontend, and also removes the color style, so that the editor matches the front end.
How has this been tested?
Using Emptytheme.
Screenshots
Before:
After:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).