-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip unstable e2e tests #33352
Skip unstable e2e tests #33352
Conversation
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
@getdave was able to track down the issue with I will start working on the fix today since I think Dave is busy working on other issues. |
@Mamaduka that's great to hear, thanks :) |
@youknowriad Sorry about that! The fix in core was intended to help the tests become more stable (through allowing reducing the test times/timeouts), not less. It's still not clear to me why it would cause this test to fail. Looking at reproducing, and alternate approaches to solving the original issue. |
No worries @getsource I'm not sure either about it. @kevin940726 might know more. |
@getsource No worries! Feel free to ping me on Slack if you need more info :) |
Just a quick note that I reverted the change in core, so the @kevin940726 Thanks much for the offer -- would love work together on finding a fix. I left some details on the trac ticket with what I do and don't understand about the behavior so far. |
I just merged #33362. I think we can re-enable the "Save flow should work as expected" test. |
@Mamaduka let's do it and restart two or three times on the PR and merge if stable |
Unfortunately, some e2e tests remain very unstable.
It's becoming very blocking for PRs and work on the repo. Please if you have some time, check some of the skipped e2e tests and try to enable them again.