Prevent color panel from showing as empty #33369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Feature] Design Tools
|
Size Change: +47 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
oandregal
force-pushed
the
update/conditions-to-hide-color-panel
branch
from
c7b9771
to
33e42f0
Compare
youknowriad
approved these changes
Jul 13, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2021
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jul 13, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33304
Alternative to #33311
The color panel visibility logic is not accounting for the colors the block actually supports, resulting in cases in which it's empty.
How to test
Block doesn't support gradients and they are the only enabled
Described at #33304
block.jsonof any block:theme.jsonof a theme (e.g.: empty theme):{ "version": 1, "settings": { "color": { "custom": false, "palette": [], "link": false } } }The expected result is that the panel is hidden. In
trunkis shown as empty.Note: with
"link": truethe panel should also be hidden, as the link depends on solid colors being available, and they aren't with the piece of code above.Block only supports link and gradients but they are disabled
Described at #33311 (comment)
Add this to the
block.jsonof any block (e.g.: paragraph):Add this to the
theme.jsonof a theme (e.g.: empty theme):{ "version": 1, "settings": { "color": { "customGradients": false, "gradients": [], "link": false } } }The expected result is that the panel is hidden. In
trunkis shown as empty.Other situations
Play a bit with the block.json and theme.json settings and verify that it works as expected: all colors can be via
theme.json, only some of them enabled, etc.