Block Editor: Warn only in edit implementation when using useBlockProps
#33380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` without a light block wrapper
gziolo
added
[Type] Bug
kevin940726
reviewed
Jul 13, 2021
packages/block-editor/src/components/block-list/use-block-props/index.js
Outdated
Show resolved
Hide resolved
Props to @mcsf for the suggestion.
|
Size Change: +29 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
…ncy in useSelect Props to @kevin940726 for detecting it.
7 tasks
mcsf
approved these changes
Jul 13, 2021
mcsf
reviewed
Jul 13, 2021
packages/block-editor/src/components/block-list/use-block-props/index.js
Outdated
Show resolved
Hide resolved
…s/index.js Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #33274.
As reported by @talldan and @kevin940726, the warning for using
useBlockPropswithapiVersion1 triggers even when blocks don't useuseBlockPropsin theeditimplementation. This is because the same hook is used by the block editor internally. This PR ensures that the warning is shown only when intended.How has this been tested?
Go to the Widgets screen an insert the Legacy Widget block and confirm there are no warnings in the Browser Console.
To ensure that the warning still triggers as intended, updated one of the core blocks that use
useBlockPropsto haveapiVersionset to 1 – for example the Heading block. Insert it into the post and you should see the warning:Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).