-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Run Prettier after regenerating test fixture #33502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
[Type] Code Quality
Issues or PRs that relate to code quality
labels
Jul 16, 2021
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
gziolo
changed the title
Docs: Run Prettier after regenerating test fixture
Tests: Run Prettier after regenerating test fixture
Jul 19, 2021
ramonjd
added a commit
to ramonjd/gutenberg
that referenced
this pull request
Jul 20, 2021
All we needed to do was add `__deprecated` to the file name so that the fixture test regex could find it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #30795.
This PR adds Prettier formatting as the last step after updating autogenerated test fixtures when executing:
npm run fixtures:regenerate
As part of this PR I moved block test fixtures from
packages/e2e-tests/fixtures
folder totest/integration
since they are longer used with E2E tests.I also removed
packages/e2e-tests/fixtures/block-transforms.js
file that is no longer in use.How has this been tested?
Ensure there are no changes after running
npm run fixtures:regenerate
on the same branch.Ensure that npm run format doesn't update *.json files.
Make sure that unit tests still pass:
npm run test-unit
.