Fix console errors when an Inner Block is deleted, and when using lightBlockWrapper #33572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +3 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
It looks like it's a deeper issue related to block re-rendering. Somehow, the block wrapper is trying to access a block object that is no longer present in the post. We should investigate it further because there might be more issues related to that. Ideally, we should bail out from re-rendering as early as possible when the block is no longer present in the post. @youknowriad, might it be related to async block updates mechanic? |
gziolo
added
[Package] Block editor
|
#32088 tried to resolve this, but apparently not entirely? |
|
I missed this PR and I applied some of the changes myself 😅 It looks like there are some of the changes that we still want to land. There is now even a tracking issue for similar issues in the codebase: #34462. @mikejolley, would you mind rebasing this PR? I'd like to test it and land next week. |
mikejolley
force-pushed
the
fix/inner-block-removal-errors
branch
from
0cd05c7 to
631f23a
Compare
|
@gziolo after rebasing it looks like your changes supercede this so Ill just close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am using some Inner Blocks that use apiVersion 2 and the light block wrapper. When one of these inner blocks are deleted, the console fills with errors:
This is because some API methods such as
getBlockName,getBlockType, andgetBlockAttributesreturn null or undefined once a block has been removed. My fix is to check that a value is returned first within the affected hooks. cc @nerradDiscovered in woocommerce/woocommerce-blocks#4479
Steps to Reproduce
Edit: I found a way to reproduce this with only Gutenberg blocks.
How has this been tested?
Tested before and after patch and ensured the errors were not logged to the console and there was no regression in inner block functionality. Running locally using WP Local environment. The blocks affected by this bug are part of woocommerce-gutenberg-products-block.
Types of changes
Bug fix - Checking variables exist.
Checklist:
*.native.jsfiles for terms that need renaming or removal).