Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reflect new automated process for feature grouping #33573

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jul 20, 2021

Description

In #33229 we added automation to the release tooling to attempt to auto-categorize the grouping of PRs by "feature".

This PR updates the docs to reflect that and to add information on exactly how you should look to curate the changelog in response to what the script will output.

How has this been tested?

Reading and checking for accuracy.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@getdave getdave added [Type] Developer Documentation Documentation for developers [Type] Build Tooling Issues or PRs related to build tooling developer-docs labels Jul 20, 2021
@getdave getdave requested review from noisysocks and gwwar July 20, 2021 14:39
@getdave getdave self-assigned this Jul 20, 2021
@getdave getdave requested review from gziolo and talldan July 29, 2021 16:07
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only other thing I did was to ping a few folks who'd worked on, reviewed or merged an uncategorized PR to let them know why the labels are important.

It'd be good to have an automated task do this, but in the meantime it could also be worth mentioning in the docs.

@gziolo
Copy link
Member

gziolo commented Jul 30, 2021

The only other thing I did was to ping a few folks who'd worked on, reviewed or merged an uncategorized PR to let them know why the labels are important.

Could we add a logic to Pull request automation workflow that fails the check if there are no labels? Ideally, one of them should be prefixed with [Type] and the other one should map to one of the feature groups.

@getdave getdave merged commit 13fe6ef into trunk Jul 30, 2021
@getdave getdave deleted the update/release-docs-with-info-on-feature-grouping branch July 30, 2021 08:47
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants