Add: Sidebar/widget block #33952
Closed
Add: Sidebar/widget block #33952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +93 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
add/sidebar-widget-block
branch
from
4966000 to
368c79f
Compare
|
Do we expect widget areas to move as they are to universal themes? |
I'm not sure. What would be useful is to be able to define a portion of a block theme that can contain widgets, so that it can be modified by users without using the site editor. |
|
Please help me understand, is this only about backwards compatibility? You wrote that, this is about not having to use the site editor -but for block themes, the widget screen is not present, so there is no natural way to edit and move the widgets without changing the block in any of the multiple editors. |
|
Also, one of the problems with the current widget area functions is the naming, widget areas are not only sidebars, so I would suggest removing that part of the naming. |
|
This is part of the work we are doing on Universal Themes. The benefit of this approach is that it would allow users who are using the old wp-admin interfaces to keep customizing their theme using the same tools as before, even if its a block theme. The benefit of this is that we can start building block themes now before the site editor is ready, and then when the Site Editor (and users) are ready, they can transition to the new tool without switching themes. |
|
Thank you for explaining. Is there an overview issue for "the work we are doing on Universal Themes"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an idea to work with this PR: https://href.li/?https://github.com/Automattic/themes/pull/4369
This is just a light wrapper around the WordPress function
dynamic_sidebarso that we can display widget areas in block themes. I noticed that there's already similar code inside theedit-widgetspackage but I couldn't work out how to implement it.This doesn't yet work in the editor - the purpose of the PR is really just to get feedback on the idea and see if there's a better way to achieve the same thing.
How has this been tested?
<!-- wp:sidebar-widget-area {"id":"sidebar-1"} /-->Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).