Remove all dashicon usages from Storybook stories
#33984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
ciampo
force-pushed
the
fix/storybook-remove-dashicons-examples
branch
from
b6eefae to
d3de340
Compare
|
This PR has been stale for a while. I've just rebased and pushed a couple of tweaks, it'd be great if it could get reviewed soon 🙇♂️ |
youknowriad
approved these changes
Sep 15, 2021
ciampo
force-pushed
the
fix/storybook-remove-dashicons-examples
branch
from
d3de340 to
34dcd8e
Compare
Thank you for the review! I've rebased, will merge as soon as all checks pass Noticing failing React Native tests, but they don't seem related (and have been affecting other branches too) — going to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the
dashiconsstyles are not included in Storybook, currently all instances ofDashiconin Storybook are not being displayed (an empty<span />is rendered without any associated icon styles). Furthermore, although Dashicons are not deprecated, their use is currently not encouraged.Since the
Dashiconcomponent is rendered when theiconprop of the<Icon />component is passed as astringtype, this PR aims at fixing the Storybook stories by swapping all those string values with SVG icons from the@wordpress/iconspackage.How has this been tested?
Compare the Storybook stories in this PR's branch (
npm run storybook:dev) against what's currently in production, and confirm that all stories using an icon are now rendering correctly.Affected components:
ButtonDropdownMenuIconModalPanelRangeControlToolbarButtonScreenshots
Example: the
IconcomponentTypes of changes
Bug fix (storybook)
Checklist:
*.native.jsfiles for terms that need renaming or removal).