Auto changelog - force group all docs tasks under Documentation
#34042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Size Change: 0 B Total Size: 1.03 MB ℹ️ View Unchanged
|
I'm tempted to add unit tests so we don't have to test changes manually for every simple modification that CI can verify. From what I see, we can extract everything after |
Yeh that's probably a good idea. But if you want to replace human review then we're going to have to assert on the final changelog output. It might be tricky to make assertions on the generated markdown. Also we'd need a large piece of fixture data. Alternatively you can assert on all the low level functions which might encourage us to break down the large functions into easily testable components. We could also weight the effort against how often we change these functions. |
|
Forgot to say you don't have to have a GH token to run the test. So verifying this PR becomes
|
|
I have a prototype for the unit test ready at #34049 😄 |
7 tasks
getdave
force-pushed
the
try/auto-changelog-force-group-all-docs-tasks
branch
from
8015a68 to
9483157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #33719 we decided we should force all docs tasks to appear under the main "Documentation" section.
That's what this PR does. It does is very manually but that's ok as it's an exception.
How has this been tested?
Run
npm run changelog -- --milestone="Gutenberg 11.3"Documentationsection.Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).