Spacing/Dimensions Supports: Separate spacing from dimensions for compatibility purposes #34059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #32392
Description
This PR addresses an issue of compatibility with core created by the renaming of spacing to dimensions support in #32392.
spacing.php
has been restoreddimensions.php
server-side hook remains in place ready to accept height and width supportspacing
containspadding
andmargin
supportspacing
key.dimensions
will containheight
,width
, and possibly min/max versions of those.__experimentalDimensions
keydimensions
keyHow has this been tested?
npm run test-unit:watch packages/block-editor/src/hooks/test/style.js
npm run wp-env run phpunit 'phpunit -c /var/www/html/wp-content/plugins/gutenberg/phpunit.xml.dist --verbose --filter stylesheet /var/www/html/wp-content/plugins/gutenberg/phpunit/class-wp-theme-json-test.php'
Types of changes
Bug fix.
Checklist:
*.native.js
files for terms that need renaming or removal).