Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experiment] Try Playwright #34089

Closed
wants to merge 44 commits into from
Closed

[Experiment] Try Playwright #34089

wants to merge 44 commits into from

Commits on Sep 28, 2021

  1. Try running our e2e tests using playwright 

    Update playwright packages
    @youknowriad @WunderBart
    youknowriad authored and WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    c933d8c View commit details
    Browse the repository at this point in the history

  2. Migrate to Playwright API

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    1aa6346 View commit details
    Browse the repository at this point in the history

  3. Update jest.playwright.config.js 

    - Use jest-circus runner
- Specify only a subset of tests to run (editor/blocks)
- Add some handy env options
- Remove obsolete jest-playwright.config.js
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    f65086d View commit details
    Browse the repository at this point in the history

  4. Add --runInBand for serial running

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    acca37d View commit details
    Browse the repository at this point in the history

  5. Update playwright setup 

    - Activate twentytwenty theme
- DISABLE the plugin for disabling CSS animations. We shouldn't need it anymore thanks to the auto-waiting functionality.
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    998a812 View commit details
    Browse the repository at this point in the history

  6. Refactor saveDraft util

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    415e94d View commit details
    Browse the repository at this point in the history

  7. Simplify "moved to trash" selector

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    c4bfa47 View commit details
    Browse the repository at this point in the history

  8. Classic block: skip cache-based test 

    I'm skipping this for now because setCacheEnabled is not available in Playwright as the cache is disabled by default because of separate browser context. It's worth noting though that Puppeteer's setCacheEnabled is for network cache, not disk.
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    4c43789 View commit details
    Browse the repository at this point in the history

  9. Classic block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    a2be9ec View commit details
    Browse the repository at this point in the history

  10. Gallery block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    354af20 View commit details
    Browse the repository at this point in the history

  11. Group block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    6c52f4c View commit details
    Browse the repository at this point in the history

  12. Heading block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    c137146 View commit details
    Browse the repository at this point in the history

  13. HTML block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    1a67562 View commit details
    Browse the repository at this point in the history

  14. Image block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    a5cf071 View commit details
    Browse the repository at this point in the history

  15. List block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    d95ca24 View commit details
    Browse the repository at this point in the history

  16. Missing block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    26f8ae8 View commit details
    Browse the repository at this point in the history

  17. Post Title block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    37a49fc View commit details
    Browse the repository at this point in the history

  18. Query block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    4a063aa View commit details
    Browse the repository at this point in the history

  19. Quote block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    f6824d0 View commit details
    Browse the repository at this point in the history

  20. Site Title block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    4d8daa7 View commit details
    Browse the repository at this point in the history

  21. Spacer block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    b95bec8 View commit details
    Browse the repository at this point in the history

  22. Rich Text test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    cba116d View commit details
    Browse the repository at this point in the history

  23. Columns block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    953a867 View commit details
    Browse the repository at this point in the history

  24. Cover block test: demo refactor

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    b957a10 View commit details
    Browse the repository at this point in the history

  25. See if the CI catches

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    0c99d34 View commit details
    Browse the repository at this point in the history

  26. Use test-e2e script for running the specs locally

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    8ccbd3d View commit details
    Browse the repository at this point in the history

  27. Refactor insertBlock utility 

    - Type in directly when searching for block.
- Wait for the block to be stable when focused as the layout shifts when the Inserter closes.
- Remove unnecessary waitForInserterCloseAndContentFocus call because Playwright's auto-waiting does that automagically.
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    6cc0bbf View commit details
    Browse the repository at this point in the history

  28. Refactor clickBlockToolbarButton util 

    - Remove explicit `waits` and remove the unnecessary scrollIntoView call (all thanks to auto-waiting)
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    51787bf View commit details
    Browse the repository at this point in the history

  29. Refactor clickMenuItem util 

    Doesn't really seem like we need it anymore?
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    355c807 View commit details
    Browse the repository at this point in the history

  30. Fix accidental selector nesting

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    36146d0 View commit details
    Browse the repository at this point in the history

  31. Remove hello.test.js

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    2cba1a8 View commit details
    Browse the repository at this point in the history

  32. Remove obsolete waitForSelector

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    d20e558 View commit details
    Browse the repository at this point in the history

  33. Update confusing parts copypasted from Puppeteer setup

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    913de3e View commit details
    Browse the repository at this point in the history

  34. Make devtools/headless/sloMo args usable

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    61cec23 View commit details
    Browse the repository at this point in the history

  35. Remove obsolete visibility check

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    5da8b94 View commit details
    Browse the repository at this point in the history

  36. Remove unrelated note

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    6c69a32 View commit details
    Browse the repository at this point in the history

  37. Restore the increased jest timeout 

    (Removed accidentally)
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    193d26c View commit details
    Browse the repository at this point in the history

  38. Explicitly close the inserter before focusing block

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    8f29a9a View commit details
    Browse the repository at this point in the history

  39. Simplify transformBlockTo util

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    3dc4cea View commit details
    Browse the repository at this point in the history

  40. Bring focus back to image block to hide the caption toolbar 

    It's standing in the way of the Replace button because the test image is really small.
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    f6812eb View commit details
    Browse the repository at this point in the history

  41. Update packages to see if it fixes the npm issues

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    b6258f8 View commit details
    Browse the repository at this point in the history

  42. Activate TwentyTwentyOne to align with trunk

    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    15eff88 View commit details
    Browse the repository at this point in the history

  43. Restore focus call for the Classic block 

    Addresses #34089 (comment)
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    8b9a566 View commit details
    Browse the repository at this point in the history

  44. Press ArrowLeft instead of Home key 

    Addresses #34089 (comment)
    @WunderBart
    WunderBart committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    3cdb35f View commit details
    Browse the repository at this point in the history