Fix NumberControl validation #34128
Closed
Fix NumberControl validation #34128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +202 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
👋 - thanks for working on this! I haven't seen in depth all the changes in your PR so but I'd expect to see something like changing an |
|
Hi Nik, thanks for the suggestion! I think your idea would probably work and, yes, likely with much less changes. I'm glad to give it go (and wish I'd tried that first 😢 😄 ) but I'll have to work on some other stuff before I can get back to this. |
|
@ntsekouras, I got around to trying your suggestion. I might have known what the catch would be but had forgotten. Modification of the value on While that's probably not a very common scenario, it is not easy to deal with specifically. Even if it were, it would also involve skipping some calls to I'm all ears in case I've overlooked something. |
7 tasks
stokesman
force-pushed
the
fix/number-control-validation
branch
from
69444ee
to
9b56eea
Compare
|
Closing in favor of #39260 that does much the same thing in a different way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two changes to
NumberControlbehavior:onChangewith invalid valuesblurThe changed behaviors are covered by a couple of new unit tests. I'd manually verified the behavior before writing the tests and so was quite surprised that the unit tests would not pass. I never pinpointed the issue but, on a hunch, I tried memoizing the reducers used in
NumberControlandInputControland that got the tests passing as expected. Since it seems better to have the reducers stable (so they don't run twice per render) the reducer forUnitControlis also made so.How has this been tested?
Manually and unit tests. Part of the manual testing was
Types of changes
Bug fix: #33291
Checklist:
*.native.jsfiles for terms that need renaming or removal).