Components: Extract a reusable PostTextEditor componeent #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
force-pushed
the
update/extract-reusable-post-text-editor
branch
from
fb97523 to
55d6af8
Compare
Codecov Report
@@ Coverage Diff @@
## master #3421 +/- ##
==========================================
+ Coverage 33.89% 34.71% +0.81%
==========================================
Files 250 252 +2
Lines 6723 6838 +115
Branches 1218 1260 +42
==========================================
+ Hits 2279 2374 +95
- Misses 3750 3771 +21
+ Partials 694 693 -1
Continue to review full report at Codecov.
|
gziolo
reviewed
Nov 10, 2017
| import { getEditedPostContent } from '../../selectors'; | ||
| import { editPost, resetBlocks } from '../../actions'; | ||
|
|
||
| class TextEditor extends Component { |
There was a problem hiding this comment.
It should be PostTextEditor here to align with how it is exposed globally.
youknowriad
force-pushed
the
update/extract-reusable-post-text-editor
branch
from
55d6af8 to
39df508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2761 (comment)
This PR extracts PostTextEditor component to the reusable components folder by removing all layout styles from the reusable components.
Testing instructions