useDropZone: Ensure drag event targets HTMLElement #34272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to fix a TypeError that has been logged in the wild but is yet to be reproduced. In production builds, it manifests as `e.dataset is undefined`, pointing to the useDropZone hook. * Don't cast FocusTarget instance to HTMLElement prior to calling isElementInZone. * Perform type validations inside isElementInZone, then cast to HTMLElement.
|
Size Change: +25 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Aug 25, 2021
| ) { | ||
| return false; | ||
| } | ||
|
|
||
| /** @type {HTMLElement|null} */ |
There was a problem hiding this comment.
Can it still be null? It looks like the previous if statement would rule that possibility out.
There was a problem hiding this comment.
Good question! The answer is yes, there needs to be margin for null for the subsequent do/while loop. Otherwise, TS complains at elementToCheck = elementToCheck.parentElement.
There was a problem hiding this comment.
Ah, I see, I missed that it's a let and not a const. 👍
|
Thanks for the quick review, @talldan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix a TypeError that has been logged in the wild but is yet to be reproduced. In production builds, it manifests as
e.dataset is undefined, pointing to the useDropZone hook. In addition:How has this been tested?
Should have no measure impact on regular usage.
Types of changes
Code quality. Tentative bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).