Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full-screen bottom sheet animations #34425

Closed
wants to merge 5 commits into from

Commits on Aug 31, 2021

  1. Link picker dismisses iOS keyboard to ensure smooth animation

    Focus of the URL text input caused animation stutter while the iOS
    keyboard visibility toggled from hide to show to hide. To address this,
    the Android-specific keyboard dismiss logic is now applied to iOS as
    well.
    dcalhoun committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    1847875 View commit details
    Browse the repository at this point in the history
  2. Fix missing animations for full-screen bottom sheets on Android

    The `layout` conditional was removed in https://git.io/JEDdk, as it is
    no longer utilized. However, its prior presence was universally
    disabling the block it guarded. Removing the always falsey conditional
    caused the block to always run and break the Android animation.
    
    Specifically, when navigating from a full-screen bottom sheet to a
    non-full-screen bottom sheet, the `currentHeight` is always `1`. This
    results in setting the height without layout animations prior to this
    change.
    dcalhoun committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    4854d73 View commit details
    Browse the repository at this point in the history
  3. Update release notes

    dcalhoun committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    9d43b06 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Fix comment typos

    dcalhoun authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    5304fd5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42a997d View commit details
    Browse the repository at this point in the history