Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "any" step in NumberControl and RangeControl #34542
Support "any" step in NumberControl and RangeControl #34542
Changes from all commits
94d6b4a
754a708
60db8b6
c5bd97c
95969fb
28a8545
4e4173d
a3d5d41
0bef207
f4cbeb6
0e5bb09
a217293
cbc8ff0
f39dc37
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of
delta
comes from react-use-gesture and is a decimal value. It's converted to an integer in order to preserve theNumberControl
's decimal value as entered (whenstep="any"
). Done viaMath.ceil
etc. because single pixel movements produce values like: