Components: fix ToggleGroupControlBackdrop
not updating size when isAdaptiveWidth
prop changes
#34595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue occurring in
ToggleGroupControl
— the backdrop element, in charge of highlighting the selected element, doesn't currently update its size/position when theisAdaptiveWidth
prop changes.To fix this issue, this PR simply forwards the
isAdaptiveProp
from the parentToggleGroupControl
component to theToggleGroupControlBackdrop
, and it uses it as an additional dependency for theuseEffect
hook that recalculates the backdrop position/size.Fixes #34587
How has this been tested?
Screenshots
Before:
togglegroup-befire.mp4
After:
togglegroup-after.mp4
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).