Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only capture toolbars on parent Nav block when not in vertical mode #34615

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Only capture toolbars on parent Nav block when not in vertical mode #34615

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8611deb
Only capture toolbars on parent Nav block when not in vertical mode
getdave Sep 7, 2021
c1d8982
Add code comment for context and clarity about reason for change
getdave Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/block-library/src/navigation/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,11 @@ function Navigation( {
isSelected
? InnerBlocks.DefaultAppender
: false,
__experimentalCaptureToolbars: true,
// Ensure block toolbar is not too far removed from item
// being edited when in vertical mode.
// see: https://github.com/WordPress/gutenberg/pull/34615.
__experimentalCaptureToolbars:
attributes.orientation !== 'vertical',
// Template lock set to false here so that the Nav
// Block on the experimental menus screen does not
// inherit templateLock={ 'all' }.
Expand Down