Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global inserter to Nav editor screen #34619

Merged
merged 34 commits into from
Sep 14, 2021
Merged

Add global inserter to Nav editor screen #34619

merged 34 commits into from
Sep 14, 2021

Commits on Sep 14, 2021

  1. Scaffold out very basic interface

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    8b4eadb View commit details
    Browse the repository at this point in the history

  2. Wire up store state and UI

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    91c11d2 View commit details
    Browse the repository at this point in the history

  3. Add inserter button to header toolbar

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    04a1008 View commit details
    Browse the repository at this point in the history

  4. Use correct classname

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    080da88 View commit details
    Browse the repository at this point in the history

  5. Use optimal props on inserter toggle

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    ce85b36 View commit details
    Browse the repository at this point in the history

  6. Allow global inserter to insert blocks at root level of Nav block

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    a248cf2 View commit details
    Browse the repository at this point in the history

  7. Avoid displaying inserter if there are no blocks to insert

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    ff8c787 View commit details
    Browse the repository at this point in the history

  8. Hide previews as they don't provide much value here

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    cf3a33f View commit details
    Browse the repository at this point in the history

  9. Refactor Inserter to dedicate component

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    3338882 View commit details
    Browse the repository at this point in the history

  10. Remove hardcoded conditional

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    14f0e31 View commit details
    Browse the repository at this point in the history

  11. Remove unwanted ref usage

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    a30ac83 View commit details
    Browse the repository at this point in the history

  12. Add toggle button styles and remove close button on larger screens

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    c867936 View commit details
    Browse the repository at this point in the history

  13. Allow tools to show on mobile viewports

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    d721afb View commit details
    Browse the repository at this point in the history

  14. Conditionalise render of sidebar 

    Ensures main content is visible on mobile devices when sidebar is disabled. If we return a component to the secondarySidebar then the interface component will render the wrapping div which will obscure the wrapping content.
    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    88c5de6 View commit details
    Browse the repository at this point in the history

  15. Only hide undo/redo on smaller viewports

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    21b9b0e View commit details
    Browse the repository at this point in the history

  16. Simplify Navigation Block hook

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    2c3793f View commit details
    Browse the repository at this point in the history

  17. Ensure global inserter always targets root nav block

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    70354c8 View commit details
    Browse the repository at this point in the history

  18. Ensure items always inserted at end if root nav block is selected

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    8d1d7c8 View commit details
    Browse the repository at this point in the history

  19. Update to use correct exported variable name

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    497d830 View commit details
    Browse the repository at this point in the history

  20. Handle focus and tab trapping via hook

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    d28bdaf View commit details
    Browse the repository at this point in the history

  21. Rename component to make it clear it's the inserter button

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    020a9a2 View commit details
    Browse the repository at this point in the history

  22. Simplify secondary sidebar

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    2d68661 View commit details
    Browse the repository at this point in the history

  23. Alter directory structure in order to improve portability of code

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    119c6ce View commit details
    Browse the repository at this point in the history

  24. Make insertion point logic explicit

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    7518cb5 View commit details
    Browse the repository at this point in the history

  25. Add docblocks to store

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    3002c38 View commit details
    Browse the repository at this point in the history

  26. Add selector state guard

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    197204c View commit details
    Browse the repository at this point in the history

  27. Implement Browse All on quick inserter. 

    Required refactor of initial file.
    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    1136792 View commit details
    Browse the repository at this point in the history

  28. Move constant outside component body 

    Addresses #34619 (comment)
    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    02124b0 View commit details
    Browse the repository at this point in the history

  29. Add dep to useSelect

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    1571d00 View commit details
    Browse the repository at this point in the history

  30. Add another dep to useSelect

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    ed0ba2a View commit details
    Browse the repository at this point in the history

  31. Remove ref

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    7d98bcf View commit details
    Browse the repository at this point in the history

  32. Sort out Prettier's mess

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    09edddc View commit details
    Browse the repository at this point in the history

  33. Rename Inserter Button to Inserter Toggle for clarity and consistency

    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    b7da582 View commit details
    Browse the repository at this point in the history

  34. Apply correct CSS naming convention 

    Addresses #34619 (comment)
    @getdave
    getdave committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    a63d3ce View commit details
    Browse the repository at this point in the history