Add ability to hide/disable the search box in the global block inserter #34656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly to be extracted to seperate PR
getdave
added
[Feature] Inserter
|
Size Change: +50 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
7 tasks
What if plugins register their own blocks or their variations to render in the scope of the Navigation block? What if there are blocks in the Block Directory? How users would discover them when the search form is removed? |
getdave
changed the title
getdave
changed the title
After some discussion on the PR which spawned this PR, we decided to drop the idea of hiding the search box. I'm going to close this one out as not a good idea after all 😄 |
gziolo
deleted the
add/ability-to-disable-search-on-block-inserter-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #34619 we learnt that in certain circumstances it makes sense to disable the search feature UI from the global block inserter. For example, in the Nav Editor screen the proposed addition of the global block inserter doesn't need a search as there are a very limited number of blocks from which to choose
This PR
As we default the search to
true(active) this change should be fully backwards compatible with all existing usages.How has this been tested?
Tricky to test but perhaps:
packages/edit-post/src/components/secondary-sidebar/inserter-sidebar.js.showSearch={false}to the<Library />component.trunk.Screenshots
This is how the feature appears when there is no search box
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).