Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] [Embed block] - Unavailable preview fallback bottom sheet title update #34674

Merged
merged 7 commits into from
Sep 14, 2021
Merged

[RNMobile] [Embed block] - Unavailable preview fallback bottom sheet title update #34674

merged 7 commits into from
Sep 14, 2021

Commits on Sep 9, 2021

  1. Added the word embed to the bottom sheet title to make it clearer.

    @jd-alexander
    jd-alexander committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    678af14 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Added isDefaultEmbedInfo flag required by the EmbedNoPreview component

    @jd-alexander
    jd-alexander committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    29a3420 View commit details
    Browse the repository at this point in the history

  2. isDefaultEmbedInfo determines if generic label should be shown or not

    @jd-alexander
    jd-alexander committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    dc2113f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into rnmobile/embed-block-unavailable-preview-fa… 

    …llback-text-fix
    @jd-alexander
    jd-alexander committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    023e0bd View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. used constant to store embedInfoByProvider to get rid of duplicate calls

    @jd-alexander
    jd-alexander committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    a4a1c56 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into rnmobile/embed-block-unavailable-preview-fa… 

    …llback-text-fix
    @jd-alexander
    jd-alexander committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    cf54448 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Merge branch 'trunk' into rnmobile/embed-block-unavailable-preview-fa… 

    …llback-text-fix
    @jd-alexander
    jd-alexander committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    9b83582 View commit details
    Browse the repository at this point in the history