Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Update the readme for the new Nav Bar component #34751

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Mobile: Update the readme for the new Nav Bar component #34751

merged 2 commits into from
Sep 20, 2021

Conversation

enejb
Copy link
Contributor

@enejb enejb commented Sep 10, 2021 •
edited
Loading

Description

This Pr just updated the readme file of the new NabBar component added in #34309

How has this been tested?

Read the new readme does it make sense.

Screenshots

None.

Types of changes

Big fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@enejb enejb added [Feature] UI Components Impacts or related to the UI component system Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Sep 10, 2021
@enejb enejb requested a review from mkevins September 10, 2021 19:09
@enejb enejb self-assigned this Sep 10, 2021
@enejb
Copy link
Contributor Author

enejb commented Sep 10, 2021

Props to @twstokes for finding the header documentation error.

mkevins
mkevins approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good Enej! Thanks for the update! 👍

@enejb enejb merged commit 0ccb4ed into trunk Sep 20, 2021
@enejb enejb deleted the rnmobile/fix-nav-bar-readme branch September 20, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees

@enejb enejb

Labels
[Feature] UI Components Impacts or related to the UI component system Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enejb @mkevins