Lower specificity of padding declaration in group block. #34854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hat tip for the |
|
Size Change: +29 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
|
Love it. I'll give it a proper test tomorrow in a few themes, but from what I can tell from the code, this one is solid, it's good use of the selector. It lowers the specificity of the default rules to be useful when nothing else is applied, but overridable by global styles, and in turn overridable by themes. |
|
Tested with a classic theme with theme.json, and block themes. This PR works well for the group block. The problem is not limited to the group block, I think it needs to be updated for every block that changes the padding when there is a background color. |
jasmussen
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
I have my own group block + has-background rule, which looks like this by default:
.wp-block-group :where(.has-background) {
padding: $grid-unit-40;
}
That's in my editor style.
When I add properties to my theme.json, this:
"core/group": {
"spacing": {
"padding": {
"top": "100px",
"right": "100px",
"bottom": "100px",
"left": "100px"
}
}
},
I correctly get a 100px padding:
When I specifically set, using inspector controls, a padding of zero, I get this:
Indeed, this is something that can and probably should be adressed across the core blocks. |
oandregal
force-pushed
the
fix/padding-for-group-with-background
branch
from
ad44d1e
to
642e808
Compare
oandregal
force-pushed
the
fix/padding-for-group-with-background
branch
from
642e808
to
f527642
Compare
|
Rebased to get #34874 in (so the e2e test passes). |
15 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33456
This PR lowers the specificity of the padding declaration for the group block when it has a background attached, so other styles (including global styles) can override them.