Heading: refactor away from the createComponent function, fix TS errors
#34921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
changed the title
Heading: refactor away from the createComponent function, fix TS …Heading: refactor away from the createComponent function, fix TS errors
ciampo
commented
Sep 17, 2021
| @@ -25,7 +25,7 @@ export interface HeadingProps extends Omit< TextProps, 'size' > { | |||
| /** | |||
| * `Heading` will typically render the sizes `1`, `2`, `3`, `4`, `5`, or `6`, which map to `h1`-`h6`. | |||
| * | |||
| * @default 3 | |||
| * @default 2 | |||
There was a problem hiding this comment.
In the useHeading hook (defined in this same file), the default value of level is 2
ciampo
commented
Sep 17, 2021
| @@ -56,16 +56,17 @@ export function useHeading( | |||
| 'Heading' | |||
| ); | |||
|
|
|||
| const as = asProp || `h${ level }`; | |||
| const as = ( asProp || `h${ level }` ) as keyof JSX.IntrinsicElements; | |||
There was a problem hiding this comment.
Necessary to avoid a TypeScript error when passing this computed as prop to the View component
ciampo
commented
Sep 17, 2021
Comment on lines
+63
to
+69
| 'aria-level'?: number; | ||
| } = {}; | ||
| if ( typeof as === 'string' && as[ 0 ] !== 'h' ) { | ||
| // if not a semantic `h` element, add a11y props: | ||
| a11yProps.role = 'heading'; | ||
| a11yProps[ 'aria-level' ] = level; | ||
| a11yProps[ 'aria-level' ] = | ||
| typeof level === 'string' ? parseInt( level ) : level; |
There was a problem hiding this comment.
Fix a TypeScript error where the expected value of aria-level can only be number | undefined (and not string)
16 tasks
ciampo
added
[Feature] Component System
sarayourfriend
approved these changes
Sep 20, 2021
ciampo
deleted the
feat/components-refactor-create-component-heading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes partially #34920.
How has this been tested?
Technically there should be no behavioral changes.
The project should build, the tests should pass, the component should behave as before in Storybook and in the block editor.
Types of changes
Refactor
Checklist:
*.native.jsfiles for terms that need renaming or removal).