Components: Delete the createComponent utility function
#34929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
commented
Sep 17, 2021
| @@ -1,70 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
Not sure if these tests have any value even without the createComponent function — should we potentially keep / move them, instead of deleting them?
There was a problem hiding this comment.
Hmmm, I guess if we wanted to keep these tests we could create a function that generates a generic test suite for any component that follows that general pattern of passing hook props to View. Not sure if there's much value in that though.
There was a problem hiding this comment.
Yeah, not sure if there's much value in doing that. I guess we can just delete these tests.
16 tasks
ciampo
added
[Feature] Component System
ciampo
force-pushed
the
feat/components-refactor-create-component-delete
branch
from
a4df6e2 to
4660e50
Compare
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
sarayourfriend
approved these changes
Sep 21, 2021
stokesman
reviewed
Sep 21, 2021
| @@ -16,7 +16,8 @@ | |||
|
|
|||
| ### Internal | |||
|
|
|||
| - Renamed `PolymorphicComponent*` types to `WordPressComponent*` ([#34330](https://github.com/WordPress/gutenberg/pull/34330)) | |||
| - Renamed `PolymorphicComponent*` types to `WordPressComponent*` ([#34330](https://github.com/WordPress/gutenberg/pull/34330)). | |||
| - Deleted the `createComponent` utility function ([#34929](https://github.com/WordPress/gutenberg/pull/34929)). | |||
There was a problem hiding this comment.
This should be under Unreleased, no? I don't suppose it's going to trip anyone up though. I happened to notice this when I went to make a changelog edit in #35020 and we could update it in that PR if you'd like.
There was a problem hiding this comment.
You're correct — I missed that Unreleased header. Well spotted!
I went to make a changelog edit in #35020 and we could update it in that PR if you'd like
That would be great, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #34290.
This PR requires all of the other PRs listed in #34920 to be merged first.
How has this been tested?
Project builds successfully, there are no usages left of
createComponentin the whole repositoryTypes of changes
Cleanup (deleting unused code)
Checklist:
*.native.jsfiles for terms that need renaming or removal).