Try: Fix missing save label. #34948
Merged
Try: Fix missing save label. #34948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
|
Hi, @jasmussen I think the snapshot needs an update to fix JS unit tests. |
|
Thank you! Done. |
|
But if the draft is already saved and the text changed to Saved, like in the image above, then having a tooltip that says Save Draft is not correct? Because until there are more changes made, there is no additional draft to save? |
Agreed. The tooltip should probably not be possible to trigger from a disabled button. But this appears to be the case already in trunk — perhaps worth opening a separate issue for? |
|
The tooltip is displaying as in the PR description, |
carolinan
approved these changes
Sep 22, 2021
|
You're right (and thank you for the review), it really kind of is weird and a better solution really would be to just not show a tooltip at all. 🤔 @ellatrix I think you worked on this recently, was there some logic to the tooltip in the disabled state that I'm missing? |
|
@jasmussen Not that I know. Maybe we can try to use the |
|
Cool, would you mind if I land this one as is? We can always circle back. |
ellatrix
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The save state tooltip is missing a label:
This PR adds it back:
The gray background in that resting state is fixes separately in #34947.
Note that the ternery logic I removed here appears unneeded. The label is visually hidden on mobile, even without the logic.
Checklist:
*.native.jsfiles for terms that need renaming or removal).