Add the global styles preview to the sidebar #34991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
mtias,
oandregal,
jasmussen and
jorgefilipecosta
youknowriad
commented
Sep 21, 2021
| const fontSize = getStyle( 'root', 'fontSize' ) ?? 'initial'; | ||
| const textColor = getStyle( 'root', 'color' ) ?? 'black'; | ||
| const linkColor = getStyle( 'root', 'linkColor' ) ?? 'blue'; | ||
| const backgroundColor = getStyle( 'root', 'backgroundColor' ) ?? 'white'; |
There was a problem hiding this comment.
The fallback values for all the properties here are the browser defaults. Note that they can defer for the actual fallback in the theme if it's using CSS to define these.
|
Size Change: +323 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
mtias
reviewed
Sep 21, 2021
| export const StylePreview = () => { | ||
| const { getStyle } = useGlobalStylesContext(); | ||
| const fontFamily = getStyle( 'root', 'fontFamily' ) ?? 'serif'; | ||
| const fontSize = getStyle( 'root', 'fontSize' ) ?? 'initial'; |
There was a problem hiding this comment.
This one should be set by us: in figma it's at 80px with a box of 248x152px (on an 8px grid).
mtias
approved these changes
Sep 21, 2021
youknowriad
changed the title
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #34574
This implements a first iteration of the Global Styles Preview in the Global Styles sidebar.