Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Use npm install in React Native e2e tests #35111

Merged
merged 1 commit into from
Sep 24, 2021
Merged

[RNMobile] Use npm install in React Native e2e tests #35111

merged 1 commit into from
Sep 24, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Sep 24, 2021 •
edited
Loading

Description

React Native e2e tests are failing constantly on different branches (including trunk) when installing dependencies, so we decided to replace the command used from npm ci to npm install which looks like to address the issue. However, I'd like to note that this is a temporary solution, the goal is to address this by the changes from the PR: #34886

How has this been tested?

Verify that all PR check passes 🟢 .

Screenshots

N/A

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@fluiddot fluiddot added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Sep 24, 2021
@fluiddot fluiddot self-assigned this Sep 24, 2021
@fluiddot fluiddot requested a review from ceyhun September 24, 2021 12:25
ceyhun
ceyhun approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 React Native E2E Tests (iOS)/(Android) seem to be already failing on trunk, should be good if they pass right now.

@fluiddot
Copy link
Contributor Author

fluiddot commented Sep 24, 2021 •
edited
Loading

Both React Native E2E tests didn't get the NPM cache and passed 🟢 🎊 :

@fluiddot fluiddot merged commit 4f0a24f into trunk Sep 24, 2021
@fluiddot fluiddot deleted the rnmobile/fix/e2e-tests-npm-install branch September 24, 2021 13:43
@github-actions github-actions bot added this to the Gutenberg 11.7 milestone Sep 24, 2021
fluiddot added a commit that referenced this pull request Sep 28, 2021
@fluiddot
Revert " [RNMobile] Use npm install in React Native e2e tests (#35111)"
7c5e3ec 
This reverts commit 4f0a24f.
This was referenced Sep 28, 2021
Merged
Merged
fluiddot added a commit that referenced this pull request Sep 28, 2021
@fluiddot
Revert " [RNMobile] Use npm install in React Native e2e tests (#35111)…
a93a961 
…" (#35175)

This reverts commit 4f0a24f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyhun ceyhun ceyhun approved these changes

Assignees

@fluiddot fluiddot

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 11.7
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @ceyhun