Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a beta indicator for the global styles sidebar #35219

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Add a beta indicator for the global styles sidebar #35219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
969fc8d
Add a beta indicator for the global styles sidebar
youknowriad Sep 29, 2021
74ed0a4
Add a line-height to align the beta message.
jasmussen Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/edit-site/src/components/sidebar/global-styles-sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,9 @@ export default function GlobalStylesSidebar() {
header={
<>
<strong>{ __( 'Styles' ) }</strong>
<span className="edit-site-global-styles-sidebar__beta">
{ __( 'Beta' ) }
</span>
<Button
className="edit-site-global-styles-sidebar__reset-button"
isSmall
Expand Down
13 changes: 13 additions & 0 deletions packages/edit-site/src/components/sidebar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,16 @@
.edit-site-global-styles-color-palette-panel {
padding: $grid-unit-20;
}

.edit-site-global-styles-sidebar__beta {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be some kind of pill component maybe or something.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @sarayourfriend started working on a Tag component, but the PR (#32214) was closed prematurely

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mtias and @jasmussen in case they have more to add on such a potential component

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super temporary, we'll remove it shortly. It doesn't even need to be rendered as a tag, can be just Styles (Beta) in text. If we consider using it more for specific blocks and in the long term we can revisit.

display: inline-flex;
margin-left: $grid-unit-10;
padding: 0 $grid-unit-10;
height: $grid-unit-30;
border-radius: $radius-block-ui;
background-color: $black;
color: $white;
align-items: center;
font-size: $helptext-font-size;
line-height: 1;
}