-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra styling around "Post content" placeholder. #35243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Feature] Full Site Editing
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
labels
Sep 30, 2021
Size Change: -355 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When editing a template in the site editor, and no post content is loaded, a placeholder is shown:
This PR, similarly to #35242, takes a tiny step towards simplifying and improving CSS inheritance by simply outputting a paragraph with styles inherited by the theme:
Longer term I'd love to see better lorem ipsum text, perhaps even a feature that gives the ability to fill in the templates with a variety of content for a variety of cases. Ultimately the goal is to help the theme developer build their theme, verify their styles, and confirm things are inherited as they should. The added border and font style wasn't helping that.
That said, this is also an opportunity to improve and expand the verbiage. There's no reason we can't provide a full and descriptive paragraph here, and I'd love input.
How has this been tested?
Open the site editor, open a singular template and observe the Post Content block.
Checklist:
*.native.js
files for terms that need renaming or removal).