Polish global styles preview. #35244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
Global Styles
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
youknowriad
reviewed
Sep 30, 2021
| @@ -25,7 +25,7 @@ export const StylePreview = () => { | |||
| style={ { background: backgroundColor } } | |||
| > | |||
| <HStack spacing={ 5 }> | |||
| <div> | |||
| <div style={ { lineHeight: '1' } }> | |||
There was a problem hiding this comment.
Can we apply it in CSS maybe to this class edit-site-global-styles-preview or by adding another class here edit-site-global-styles-preview__text?
There was a problem hiding this comment.
We can, yes, I'm a bit confused at myself for adding it here in the first place. Good call.
youknowriad
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Definitely the department of subtleties. The new Global Styles preview card had an inherited line height, making it look vertially offset in some situations:
This PR just adds an explicit line height so it doesn't inherit it from a random context, therefore vertically centering it:
How has this been tested?
Open the site editor, view the global styles sidebar.
Checklist:
*.native.jsfiles for terms that need renaming or removal).