[RNMobile][Embed block] Fix URL not editable after dismissing the edit URL bottom sheet with empty value #35460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
2 tasks
jd-alexander
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
Thanks for these changes @fluiddot I utilized the referenced issue to verify that the bug existed on develop. After switching to this branch, I was able to verify that this fix works as expected by executing the test plan and observing the correct behavior of the embed bottom sheet. LGTM 🚢
# Conflicts: # packages/react-native-editor/CHANGELOG.md
5 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4094
Description
Previously, the
EmbedBottomSheetcomponent wasn't triggering theonSubmithandler when the current URL is empty and no value is set. Originally this wasn't an issue but with the changes from wordpress-mobile/gutenberg-mobile#4002, now we rely on theonSubmitnotification to determine if the URL is being edited, if it's not triggered, then the block gets locked in a state that prevents theEmbedBottomSheetto be shown again.This PR basically assures that
onSubmitis triggered in every case, including when the current URL is empty and no value is set.How has this been tested?
Dismissing with empty URL
Dismissing with invalid URL
http://?)Screenshots
embed-block-set-empty-url.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).