Iterate on the design of the colors and gradients panel #35535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +30 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Oct 12, 2021
|
I'm getting a weird unit test failure on the unit test (Reakit warning), maybe related to ToggleGroupControl component. Any idea @ntsekouras @ciampo |
mtias
added
the
[Feature] UI Components
I can see this error on the CI unit tests task: Although I'm not able to reproduce it locally, which makes it hard to debug. Maybe @diegohaz has any insights? Could it be related to some dependency version mismatch? |
Hmm, that's weird. I couldn't find anything that could be causing this warning in the code. So my best guess is that it's something with |
|
I don't Reakit code but could this something related here: https://github.com/reakit/reakit/blob/master/packages/reakit/src/Radio/Radio.ts#L100? In Reakit |
|
I converted the first test to use |
That's correct. The ref will be assigned after the component is mounted, but before effects run. So the effect callback should have access to the ref value. Since the ref is stable, there's no need to add it to the effect deps either. I guess there may be a problem between |
ciampo
approved these changes
Oct 12, 2021
|
Thanks all for your help here :) |
ciampo
reviewed
Oct 14, 2021
| isSmall | ||
| isPressed={ currentTab === 'gradient' } | ||
| onClick={ () => setCurrentTab( 'gradient' ) } | ||
| <VStack space={ 3 }> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #34574
This PR updates the color panel a bit:
This impacts both the global styles panel (background color) and blocks (cover block for instance)