Components: remove unused useJumpStep utility
#35561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ciampo
added
[Feature] Component System
|
Size Change: +273 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Thanks for following up with this PR @ciampo! The removal looks good to me, and I did a quick smoke test that nothing appears to be broken.
Also, it looks like we aren't exporting the functions from /packages/components/src/utils/ in https://github.com/wordpress/gutenberg/blob/trunk/packages/components/src/index.js, so I assume it's safe to remove the utility function without adding a removal entry to the components package changelog file.
LGTM!
|
Thank you for the quick review!
Yeah, at this point this is just an internal change. I still went ahead and added it to the CHANGELOG under the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the unused
useJumpStepfunction as discussed in #34817How has this been tested?
Project builds correctly
Types of changes
Cleanup
Checklist:
*.native.jsfiles for terms that need renaming or removal).