Do not filter template parts by the theme in which they were created #35666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] Templates API
adamziel
requested review from
draganescu,
getdave,
mtias,
noisysocks,
talldan and
gziolo
|
Size Change: -5.2 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
This looks like a step in the right direction, but will cause merge conflicts with #31971. I strongly recommend merging that one first to stop relying on the post_name field for template identifiers, and it will simplify a lot of the requirements for this task. |
7 tasks
|
This PR is now ~9 months old, got outdated, and didn't attract many reviews. I moved on to other tasks and so I'm closing this one. Feel free to pick it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A discussion in 35148 surfaced how filtering template parts by current theme is not that useful. I agree, so in this PR I propose removing the limitation.
How has this been tested?
Screenshots
Before:
After:
