Navigation: Fix issue with space-between #35722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
changed the title
|
Size Change: +31 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
7 tasks
vcanales
approved these changes
Oct 18, 2021
tw875768
added a commit
to tw875768/gutenberg
that referenced
this pull request
Oct 18, 2021
This reverts commit 024f7ea.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #34258. Maybe fixes #35549.
The navigation container block had
flex-growassigned on it, to fix a space-between issue. But this caused an issue with with states that were not space-between. Shown here in the before state in the editor, a navigation block with social links inside, next to each other as they are not space betweened:Same state, but frontend, notice how the social links are way on the right:
That's because the nav container was allowed to grow, so it took the space and pushed social links. This PR scopes that so that this growing behavior only affects the space between state.
Editor after:
Frontend after:
Space between works the same as before.
Note that this PR also applies a
gapvalue to the navigation block itself. This is to add space between menu items and other blocks, like Social Links. This already worked in the editor, but as an extra wrapper is added on the frontend, the extra gap is necessary there.How has this been tested?
Here's some test content:
Test that nav items and social links look good in the default non space between state.
Checklist:
*.native.jsfiles for terms that need renaming or removal).