Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Excerpt: Don't print the wrapper when there is no excerpt #35749

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Post Excerpt: Don't print the wrapper when there is no excerpt #35749

merged 2 commits into from
Oct 21, 2021

Conversation

carolinan
Copy link
Contributor

Description

Closes #30571
Replaces #30616
Removes the unnecessary wrapper on the front when there is no excerpt.

How has this been tested?

  1. Create a new empty post and add a post excerpt block.
  2. View the front and confirm that the markup is not printed.

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@carolinan carolinan marked this pull request as ready for review October 19, 2021 09:26
@carolinan carolinan requested a review from ajitbohra as a code owner October 19, 2021 09:26
jorgefilipecosta
jorgefilipecosta approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skorasaurus skorasaurus added the [Block] Post Excerpt Affects the Post Excerpt Block label Oct 20, 2021
@carolinan carolinan merged commit bd1a5b7 into trunk Oct 21, 2021
@carolinan carolinan deleted the update/post-excerpt-try-2 branch October 21, 2021 12:09
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Oct 21, 2021
fullofcaffeine added a commit that referenced this pull request Oct 21, 2021
@fullofcaffeine
Merge branch 'trunk' into replace/confirm-et-al
49eaa0e 
* trunk: (494 commits)
  remove consecutive rc warning (#35855)
  Update Changelog for 11.8.0-rc.2
  Bump plugin version to 11.8.0-rc.2
  [RNMobile] Disable React Native E2E Tests (iOS) (#35844)
  Add section about using the schema during development (#35835)
  Add a method to disable auto-accepting dialogs (#35828)
  Wrap NavigationContainer with SafeAreaView. (#35570)
  Update Appium to 1.22.0 (#35829)
  Post Comment: Handle the case where a comment does not exist (#35810)
  Clear selected block when clicking on the gray background (#35816)
  Post excerpt: Don't print the wrapper when there is no excerpt (#35749)
  [Block] Navigation: Fix padding for social links on mobile (#35824)
  Fix issue with responsive navigation causing wrapping. (#35820)
  [Block Editor]: Fix displaying only `none` alignment option (#35822)
  Add API to access global settings, styles, and stylesheet (#34843)
  Mobile Release v1.64.1 (#35804)
  Add resizer to template part focus mode (#35728)
  Update Changelog for 11.7.1
  Gallery block: Only show the gallery upload error message if mixed multiple files uploaded (#35790)
  Update Changelog for 11.8.0-rc.1
  ...
@andrewserong andrewserong added the [Type] Enhancement A suggestion for improvement. label Nov 5, 2021
@andrewserong andrewserong changed the title Post excerpt: Don't print the wrapper when there is no excerpt Post Excerpt: Don't print the wrapper when there is no excerpt Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras left review comments

@Mamaduka Mamaduka Mamaduka left review comments

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

@aristath aristath aristath approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 11.9
Development

Successfully merging this pull request may close these issues.

Post Excerpt and Post Content blocks output wrapping divs when the post content is empty
7 participants
@carolinan @Mamaduka @aristath @jorgefilipecosta @ntsekouras @skorasaurus @andrewserong