Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Move all the Post Editor's layout components under a "post-edit" folder #3608

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Nov 22, 2017

closes #2761

Now that we moved all the reusable editor components under the "components" folder, this PR moves the remaining components corresponding to all the components building the "post-edit" page layout to a folder named "post-edit".

Later, I think it makes sense to move all these components to a separate "post-edit" module which will require to split the Redux store to two stores: one for the layout and one for the editor data. We can also decide to avoid using a "redux" store for the layout and just stick with local state or more "modular" state approaches.

Testing instructions

  • Just make sure Gutenberg loads and works.

@youknowriad youknowriad self-assigned this Nov 22, 2017
@youknowriad youknowriad requested review from mtias and aduth November 22, 2017 08:25
@mtias
Copy link
Member

mtias commented Nov 22, 2017

Thinking of calling it edit-post instead. Once we have page templates / theme editor it would be edit-theme or edit-template and they would sit next to each other in the directory list.

@gziolo
Copy link
Member

gziolo commented Nov 22, 2017

I can confirm that it still works. editor folder looks really nice with those changes introduced 👍

@youknowriad youknowriad force-pushed the update/reorganize-post-edit-components branch from 0b48005 to 0e16235 Compare November 23, 2017 12:55
@youknowriad youknowriad force-pushed the update/reorganize-post-edit-components branch from 0e16235 to ca925d8 Compare November 23, 2017 13:19
@codecov
Copy link

codecov bot commented Nov 23, 2017

Codecov Report

Merging #3608 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3608   +/-   ##
=======================================
  Coverage   36.95%   36.95%           
=======================================
  Files         268      268           
  Lines        6673     6673           
  Branches     1202     1202           
=======================================
  Hits         2466     2466           
  Misses       3555     3555           
  Partials      652      652
Impacted Files Coverage Δ
...tor/edit-post/sidebar/post-pending-status/index.js 0% <ø> (ø)
editor/edit-post/sidebar/post-schedule/index.js 50% <ø> (ø)
editor/edit-post/sidebar/post-author/index.js 0% <ø> (ø)
editor/edit-post/sidebar/post-sticky/index.js 0% <ø> (ø)
editor/edit-post/header/publish-dropdown/index.js 0% <ø> (ø)
.../components/block-list/block-contextual-toolbar.js 0% <ø> (ø) ⬆️
editor/edit-post/sidebar/post-visibility/index.js 40% <ø> (ø)
editor/edit-post/modes/visual-editor/inserter.js 93.33% <ø> (ø)
editor/components/navigable-toolbar/index.js 5.88% <ø> (ø)
editor/edit-post/sidebar/page-attributes/index.js 0% <ø> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af0065...ca925d8. Read the comment docs.

@youknowriad youknowriad merged commit 68bf34f into master Nov 23, 2017
@youknowriad youknowriad deleted the update/reorganize-post-edit-components branch November 23, 2017 13:30
@aduth aduth mentioned this pull request Nov 27, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Expose editor components as reusable pieces
3 participants