Site Editor: Change ToolsMoreMenuGroup slot-fill name #36146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
|
Size Change: +6 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
@gziolo, @youknowriad, can I get a second opinion on this PR? Do you think this is the correct way to solve the collision issue? Thanks |
noisysocks
added
the
Backport to WP 6.7 Beta/RC
gziolo
approved these changes
Nov 8, 2021
| @@ -10,7 +10,7 @@ import { createSlotFill, MenuGroup } from '@wordpress/components'; | |||
| import { __ } from '@wordpress/i18n'; | |||
|
|
|||
| const { Fill: ToolsMoreMenuGroup, Slot } = createSlotFill( | |||
| 'ToolsMoreMenuGroup' | |||
| 'EditSiteToolsMoreMenuGroup' | |||
There was a problem hiding this comment.
I personally think that those names should become private for the SlotFill and we only keep old names for backward comaptibility.
|
|
|
Thanks for the review, @gziolo. |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 10, 2021
andrewserong
pushed a commit
that referenced
this pull request
Nov 10, 2021
andrewserong
added
the
Backport to WP 6.7 Beta/RC
|
Cherry picked into the Gutenberg 11.9 release in: 1119b76 |
andrewserong
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
ToolsMoreMenuGroupSlotFill name toEditSiteToolsMoreMenuGroup. This will help us to avoid collision with the edit post packages'ToolsMoreMenuGroup.We need package-specific SlotFill to correctly add the "Keyboard shortcuts" and "Welcome Guide" modal menu items.'
Required for #21245 and #32844
How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).