Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Area block #36178

Merged
merged 36 commits into from
Nov 5, 2021
Merged

Navigation Area block #36178

merged 36 commits into from
Nov 5, 2021

Commits on Nov 5, 2021

  1. try nav-area-block

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    6e365e0 View commit details
    Browse the repository at this point in the history

  2. Resolve conflicts with trunk

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    9c3354f View commit details
    Browse the repository at this point in the history

  3. Rely on contexts also in PHP navigation block's render callback

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    c9ee028 View commit details
    Browse the repository at this point in the history

  4. Lint and typo fixes

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    228b376 View commit details
    Browse the repository at this point in the history

  5. Add a description for the navigation area block

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    e87f27d View commit details
    Browse the repository at this point in the history

  6. Remove navigation area and unused functions

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    b65423b View commit details
    Browse the repository at this point in the history

  7. Update navigation area example

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    3ac3119 View commit details
    Browse the repository at this point in the history

  8. Remove unused attribute

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    dc82243 View commit details
    Browse the repository at this point in the history

  9. Minor copy update

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    96f60cf View commit details
    Browse the repository at this point in the history

  10. Try passing the correct menu id into the template

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    2ffe39a View commit details
    Browse the repository at this point in the history

  11. Only build template when menu id is known and add loading state

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    544169a View commit details
    Browse the repository at this point in the history

  12. Show navigation block placeholder when in an unassigned navigation area

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d7bdda1 View commit details
    Browse the repository at this point in the history

  13. Support deleting menus in navigation areas

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    0ab571d View commit details
    Browse the repository at this point in the history

  14. Add location keyword

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d23b0e3 View commit details
    Browse the repository at this point in the history

  15. Remove unused stylesheet

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    1752fe5 View commit details
    Browse the repository at this point in the history

  16. Replace references to menu locations with navigation areas

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    32d48d0 View commit details
    Browse the repository at this point in the history

  17. Remove links from the first version

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    1484347 View commit details
    Browse the repository at this point in the history

  18. Add gutenberg_register_navigation_areas that enables overriding the d… 

    …efault navigation areas.
    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    86af65c View commit details
    Browse the repository at this point in the history

  19. Rename "menu" property returned by the REST API to "navigation"

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    c6dfa11 View commit details
    Browse the repository at this point in the history

  20. Replace a call to get_item() in update_item() with an encapsulation (… 

    …common get_navigation_area_object function)
    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    6b4fdd6 View commit details
    Browse the repository at this point in the history

  21. Remove @Validate comment and follow the menu-items endpoint in not va… 

    …lidating the db object ID.

It would be great to add one at some point, but right now the way
gutenberg saves data is by issuing multiple concurrent http requests, so
there is a huge potential for race conditions.
    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    7238ed2 View commit details
    Browse the repository at this point in the history

  22. Remove @todos related to changing permissions checks. The checks are … 

    …fine.
    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    665637b View commit details
    Browse the repository at this point in the history

  23. Restore the // Experimental blocks. comment

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    dfe6abb View commit details
    Browse the repository at this point in the history

  24. Preload navigation areas in the site editor

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d1bb992 View commit details
    Browse the repository at this point in the history

  25. Use templateLock: 'all' for navigation area inner blocks

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    b24c048 View commit details
    Browse the repository at this point in the history

  26. Add missing fixtures

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    4351726 View commit details
    Browse the repository at this point in the history

  27. Add file doc comment

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    9586f41 View commit details
    Browse the repository at this point in the history

  28. Remove navigation menu bugfix so that it can be extracted into anothe… 

    …r PR
    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    03f96d0 View commit details
    Browse the repository at this point in the history

  29. Adjust fixtures

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    7522956 View commit details
    Browse the repository at this point in the history

  30. Adjust fixtures

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    76501b7 View commit details
    Browse the repository at this point in the history

  31. Adjust fixturs

    @adamziel @talldan
    adamziel authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    a467be3 View commit details
    Browse the repository at this point in the history

  32. Update lib/class-wp-rest-block-navigation-areas-controller.php 

    Co-authored-by: Anton Vlasenko <43744263+anton-vlasenko@users.noreply.github.com>
    @draganescu @anton-vlasenko @talldan
    2 people authored and talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    e31fdfb View commit details
    Browse the repository at this point in the history

  33. Remove div from save content

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    40349db View commit details
    Browse the repository at this point in the history

  34. Fix REST API registration variable nameing

    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    e7bc4a1 View commit details
    Browse the repository at this point in the history

  35. Revert "Update lib/class-wp-rest-block-navigation-areas-controller.php" 

    This reverts commit e31fdfb.
    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    5956983 View commit details
    Browse the repository at this point in the history

  36. Avoid trying to preload post with 0 id, which is default for a naviga… 

    …tion area
    @talldan
    talldan committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    b283ea3 View commit details
    Browse the repository at this point in the history