Updates WP_Theme_JSON_Resolver and tests to be equal to core
#36223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
| * | ||
| * @return string|string[]|array[] Translated settings. | ||
| */ | ||
| function gutenberg_translate_settings_using_i18n_schema( $i18n_schema, $settings, $textdomain ) { |
There was a problem hiding this comment.
These functions are already part of the core. Are they part of 5.8 if yes we can just remove the Gutenberg versions and use core.
There was a problem hiding this comment.
As far as I saw, they were introduced in August, post-5.8 release.
jorgefilipecosta
approved these changes
Nov 4, 2021
Mamaduka
reviewed
Nov 5, 2021
| gutenberg_experimental_set( $theme_json, $path, $translated_array ); | ||
| } | ||
| if ( null === self::$i18n_schema ) { | ||
| $i18n_schema = wp_json_file_decode( __DIR__ . '/theme-i18n.json' ); |
There was a problem hiding this comment.
I think this should be gutenberg_json_file_decode, or we should rename the function. It is causing a fatal error, and I'm not able to access the site editor.
Mamaduka
reviewed
Nov 5, 2021
| } | ||
|
|
||
| return $theme_json; | ||
| return translate_settings_using_i18n_schema( self::$i18n_schema, $theme_json, $domain ); |
There was a problem hiding this comment.
This line as well.
PHP Fatal error: Uncaught Error: Call to undefined function wp_json_file_decode() in gutenberg/wp-content/plugins/gutenberg/lib/class-wp-theme-json-resolver-gutenberg.php:101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related WordPress/wordpress-develop#1808
This PR adapts the Gutenberg code to be like WordPress core, so it's easier to identify changes. In this commit, we made changes to the class in WordPress core that weren't ported to Gutenberg.
How to test
Verify tests pass.