-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate classic menus to block-based menus on theme switch #36255
Conversation
…m:WordPress/gutenberg into try/migrate-classic-menus-on-theme-switch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find @getdave, let's address this in a follow-up PR |
Merged with "admin" because all checks were green except build artefact with was stuck on some network problem. |
What about menus that used in widgets / hardcoded in templates. Locations are not the only way to know if a menu is being used. |
Nonetheless, I'd say the locations route covers the 80% use case. Widgets/hard coding is possible, and completely valid, but seems less likely. Do you have any ideas for route we could all explore that could help cover those scenarios [the ones you mentioned] as well? |
Description
Adds an action that acts on
theme_switch
and:fse_navigation_areas
to reflect these migrated menusgutenberg_migrate_nav_on_theme_switch
is the only new function, the other ones were copied over from the navigation block. It would be great to remove the duplication in a follow-up PR.How has this been tested?