Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CSS that causes conflict with theme.json #36424

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Remove CSS that causes conflict with theme.json #36424

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be82e2e
Remove CSS that causes conflict with theme.json
ndiego Nov 12, 2021
bf2f900
Add back styling but with lower specificity.
ndiego Nov 12, 2021
579377c
Fix linting errors.
ndiego Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/block-library/src/columns/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@

// Individual columns do not have top and bottom margins on the frontend.
// So we make the editor match that.
// Needs specificity.
.block-editor-block-list__block.wp-block-column.wp-block-column {
// We use :where to provide minimum specificity, so that intentional margins,
// such as those configured in theme.json, override and win on specificity.
html :where(.wp-block-column) {
margin-top: 0;
margin-bottom: 0;
}